Open
Conversation
|
The compilation is starting. Take a look here. |
|
The compilation is starting. Take a look here. |
|
Everything is OK. Thank you for the PR! |
1 similar comment
|
Everything is OK. Thank you for the PR! |
|
The compilation is starting. Take a look here. |
|
The compilation is starting. Take a look here. |
|
Everything is OK. Thank you for the PR! |
1 similar comment
|
Everything is OK. Thank you for the PR! |
Contributor
|
This looks like a really granular and small example. I don't think it makes sense to create a brand new example instead of adding the relevant code to the documentation, the KB, or incorporating it into an existing example. |
alexcamposruiz
requested changes
Jan 26, 2024
| { EnumMember("off", 0), EnumMember("on", 42) }); | ||
| } | ||
|
|
||
| DynamicType create_struct_dynamic_type() |
Contributor
There was a problem hiding this comment.
It can be simplified:
{
return StructType("EnumStruct", { {"engine_state_element", create_enum_type() } });
}
| { EnumMember("off", 0), EnumMember("on", 42) }); | ||
| } | ||
|
|
||
| DynamicType create_struct_dynamic_type() |
Contributor
There was a problem hiding this comment.
Suggested change
| DynamicType create_struct_dynamic_type() | |
| StructType create_struct_dynamic_type() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an example that shows how to use DynamicData Enums and get their member ordinal values by name (string).
Checks
examples/connext_dds/CMakeList.txtaccordingly.